Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement designed UI/UX #235

Merged
merged 1 commit into from
Aug 8, 2024
Merged

feat: implement designed UI/UX #235

merged 1 commit into from
Aug 8, 2024

Conversation

kittybest
Copy link
Contributor

@kittybest kittybest commented Aug 2, 2024 •
edited
Loading

@vercel Vercel
Copy link

vercel bot commented Aug 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maci-rpgf ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2024 7:47pm

@kittybest kittybest self-assigned this Aug 2, 2024
@kittybest
Copy link
Contributor Author

kittybest commented Aug 5, 2024 •
edited
Loading

The very first commit message does not meet the commitlint rules, we can do either

  1. rebase -i: to reword the commit message, but still need to solve the conflicts through dozens of commits
  2. squash commits: would lose the tracking history of this PR

@kittybest
Copy link
Contributor Author

kittybest commented Aug 5, 2024 •
edited
Loading

I found something: the eslintignore in each packages is no use (? the eslintignore file in the root is actually working. So my question is: should we just remove the eslintignore files inside packages?

ctrlc03
ctrlc03 approved these changes Aug 5, 2024
View reviewed changes
Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 thank you

0xmad
0xmad reviewed Aug 5, 2024
View reviewed changes
Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kittybest thanks, just some comments

packages/interface/src/features/applications/components/ApplicationsToApprove.tsx Outdated Show resolved Hide resolved
packages/interface/src/features/applications/components/ApplicationsToApprove.tsx Show resolved Hide resolved
packages/interface/src/features/applications/components/ApplicationButtons.tsx Outdated Show resolved Hide resolved
packages/interface/src/components/SortByDropdown.tsx Outdated Show resolved Hide resolved
0xmad
0xmad approved these changes Aug 6, 2024
View reviewed changes
Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kittybest thanks!

@kittybest
Copy link
Contributor Author

The maci versions should be update to v2.0.1 after it released.

@kittybest kittybest merged commit 18fd498 into main Aug 8, 2024
11 checks passed
@kittybest kittybest deleted the feat/design-ui branch August 8, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctrlc03 ctrlc03 ctrlc03 approved these changes

@0xmad 0xmad 0xmad approved these changes

@crisgarner crisgarner Awaiting requested review from crisgarner crisgarner is a code owner

Assignees

@kittybest kittybest

Labels
None yet
Projects
MACI
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kittybest @0xmad @ctrlc03